Skip to content

chore: remove yarn-error.log #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2018
Merged

chore: remove yarn-error.log #484

merged 2 commits into from
Jul 11, 2018

Conversation

sinchang
Copy link
Contributor

No description provided.

@@ -5,3 +5,4 @@
/node_modules
/test.*
yarn.lock
yarn-error.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a final newline here. See the .editorconfig.
Otherwise I fully agree with you, there's no need to add this file to version control.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinchang, good catch

@michalsnik michalsnik merged commit 0b86a4e into vuejs:master Jul 11, 2018
@sinchang sinchang deleted the patch-1 branch July 11, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants