⭐️New: Add rule no-boolean-default
#612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2018 14:25
mysticatea
reviewed
Oct 20, 2018
added 2 commits
October 21, 2018 17:20
|
Thank you @mysticatea I made the updates! Let me know if there's anything else I can do. |
armano2
suggested changes
Oct 27, 2018
|
@armano2 Oops I misread his comment to add the spread outside of the prop schema. I updated the PR, thanks for catching |
armano2
approved these changes
Oct 29, 2018
|
@hirokiosame thank you 👍 |
michalsnik
suggested changes
Nov 7, 2018
ota-meshi
reviewed
Nov 9, 2018
armano2
suggested changes
Nov 11, 2018
armano2
suggested changes
Nov 11, 2018
michalsnik
approved these changes
Jan 29, 2019
|
@armano2 I updated this PR, please take a look one more time :) |
armano2
approved these changes
Jan 29, 2019
|
Looks great, thanks for the updates @michalsnik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added documentation yet but I can add one if you guys like the rule.
The rule prevents Boolean props from having a default value. I put this under
essentialas it follows HTML standards of always defaulting boolean attributes to false. Otherwise, users would have to do:prop="false"to turn it off.The rule has the following options:
'constructor'(default) enforces that Boolean props must use the constructor.'no-default'allows a prop definition object, but enforces that thedefaultproperty not be defined.'default-fase'enforces that the default can be set but must be set tofalse.