-
-
Notifications
You must be signed in to change notification settings - Fork 681
New: some core rules for <template> #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # README.md # lib/index.js
should we keep meta.url from eslint or should we override it to our doc? { docs: Object.assign({}, coreRule.meta.docs, { category }) } replaces #599 |
f5a304e
to
cde4a3b
Compare
cde4a3b
to
b476621
Compare
I updated to override |
Awesome! |
@mysticatea would you mind updating docs? And we could proceed with this :) Sorry for slow response here.. |
# Conflicts: # README.md # lib/index.js
I updated this PR for conflictions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
Maybe you should consider showing a warning that these rules are not yet available in the latest version of the plugin since it was release 9 days ago and this was merged 6 days ago ? |
This PR proposes to add the wrappers of some core rules to apply those to the expressions in
<template>
.Those are simple wrappers. For example:
It would be useful for styling embedded expressions.
Probably I need to separate PRs per rule.