Skip to content

New: some core rules for <template> #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 5, 2019
Merged

New: some core rules for <template> #680

merged 13 commits into from
Jan 5, 2019

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Nov 26, 2018

This PR proposes to add the wrappers of some core rules to apply those to the expressions in <template>.

Those are simple wrappers. For example:

const { wrapCoreRule } = require('../utils')
module.exports = wrapCoreRule(require('eslint/lib/rules/array-bracket-spacing'))

It would be useful for styling embedded expressions.


Probably I need to separate PRs per rule.

@armano2
Copy link
Contributor

armano2 commented Nov 26, 2018

should we keep meta.url from eslint or should we override it to our doc?

{ docs: Object.assign({}, coreRule.meta.docs, { category }) }

replaces #599

@mysticatea
Copy link
Member Author

I updated to override meta.docs.url.

@ota-meshi
Copy link
Member

Awesome!

@michalsnik
Copy link
Member

@mysticatea would you mind updating docs? And we could proceed with this :) Sorry for slow response here..

@mysticatea
Copy link
Member Author

I updated this PR for conflictions.

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@michalsnik michalsnik merged commit ebd07e6 into master Jan 5, 2019
@michalsnik michalsnik deleted the some-core-rules branch January 5, 2019 15:29
@mrleblanc101
Copy link

Maybe you should consider showing a warning that these rules are not yet available in the latest version of the plugin since it was release 9 days ago and this was merged 6 days ago ?
I've spend many hours yesterday figuring out why 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants