fix(use-v-on-exact): Reimplement algorithm to catch cases more properly #750
+426
−101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #727
I changed a bit how the rule works and now I'm reporting events only if one of the key modifiers have been used. That prevents reports about cases like
@mouseenter="foo" @mouseenter.once="bar"
.I also compare all system modifiers chains for given event, and report cases, that have previously been omitted, like:
Additionally I distinct native elements from components, and for components I only compare events that have
native
modifier. So we'll no longer report this as an error:If you have any additional case that come to your mind, please share them.