Skip to content

Chore: update vue-eslint-parser #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2019
Merged

Chore: update vue-eslint-parser #754

merged 2 commits into from
Jan 26, 2019

Conversation

mysticatea
Copy link
Member

Fixes #716
Fiees #722
Fixes #733

See the release note https://github.com/mysticatea/vue-eslint-parser/releases/tag/v5.0.0 for details.

  • No rule looks to depend on VSlotScopeExpression#id property that was removed.
  • As a side effect, it gets ignoring expressions in the attributes of the top-level tags. This affects some test cases and I wrapped those tests by <template> element.

@mysticatea
Chore: update vue-eslint-parser
ff58f63 
Fixes #716
Fiees #722
Fixes #733

As a side effect, it gets ignoring expressions on outside of the
template.
@michalsnik
Copy link
Member

Looks like we did the same thing, look at #753

@michalsnik michalsnik merged commit 97a51b2 into master Jan 26, 2019
@michalsnik michalsnik deleted the vue-eslint-parser/5 branch January 26, 2019 09:05
@OlegGavrilov OlegGavrilov mentioned this pull request Jan 30, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armano2 armano2 armano2 approved these changes

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mysticatea @michalsnik @armano2