-
Notifications
You must be signed in to change notification settings - Fork 546
Redesign the position object returned by scrollBehavior
#176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f2ab0ec
to
b108642
Compare
How does this handle RTL-scrolling elements, where the |
@JosephSilber since it's using |
Looking really good! Is the scrollBehavior called after the transition? Because using querySelector may return null if the transition is not done right? 🧐 |
Like with v3, you need to wait for the transition to be finished inside of scrollBehavior. I didn't mention it but it still supports a Promise, like in v3 |
BREAKING CHANGE: this change follows the RFC at vuejs/rfcs#176: - `selector` is renamed into `el` - `el` also accepts an `Element` - `left` and `top` are passed along `el` instead of inside an object passed as `offset`
This RFC is now in final comments stage. An RFC in final comments stage means that: The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believes that this RFC is a worthwhile addition to the framework. |
3ffd047
to
6f8289c
Compare
Rendered