Skip to content

Suspended component in nested route result in child route mounted twice #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wuhaodes opened this issue Feb 25, 2022 · 1 comment
Closed

Suspended component in nested route result in child route mounted twice #1324

wuhaodes opened this issue Feb 25, 2022 · 1 comment
Labels
bug Something isn't working external This depends on an external dependency but is kept opened to track it feat:suspense

Comments

@wuhaodes
Copy link

wuhaodes commented Feb 25, 2022 •
edited by posva
Loading

Version

4.0.0

Reproduction link

codesandbox.io

Steps to reproduce

https://codesandbox.io/s/lively-mountain-o395nx?file=/src/UserCenter/Push.vue

What is expected?

push once

What is actually happening?

push twice
@posva posva added bug Something isn't working feat:suspense labels Feb 25, 2022
posva added a commit that referenced this issue Feb 28, 2022
@posva
test: add failing nested suspense for #1324
b28ee2d
@posva posva mentioned this issue Mar 3, 2022
Closed
@posva posva added the external This depends on an external dependency but is kept opened to track it label May 29, 2022
@posva posva changed the title useRouter.push/$router.push router-link will push page twice Suspended component in nested route result in child route mounted twice Jun 24, 2022
@zkulbeda zkulbeda mentioned this issue Jun 29, 2023
Closed
@posva posva moved this to Planned in Vue Router Roadmap Apr 17, 2024
@posva posva moved this from Planned to In discussion in Vue Router Roadmap Apr 17, 2024
@posva
Copy link
Member

posva commented Feb 5, 2025

I tested with up-to-date dependencies and there is no longer a double push. This was patched in vuejs/core#10055

@posva posva closed this as completed Feb 5, 2025
@github-project-automation github-project-automation bot moved this from 💬 In discussion to ✅ Done in Vue Router Roadmap Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working external This depends on an external dependency but is kept opened to track it feat:suspense
Projects
Vue Router Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@posva @wuhaodes