-
Notifications
You must be signed in to change notification settings - Fork 266
Export MountingOptions interface #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 If it's now public, we could even add documentation on each option (they would show up in IDE)
Sure, that'd be great! However, it is not related to making the interface public, right? As far as I know, people using VTU is already "seeing" the outputs of the interface. |
Right, but it's a good rule of thumb that exported types should be documented. I'm fine merging it like this though, it was just nitpicking :) |
no prob! I'll update this with some documentation :) |
Done! Decided to move type into |
@afontcu 👏 thank you for taking the time to do this! LGTM |
totally worth it! It also helped me identify several missing keys in our docs. Working on it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true beauty is documenting each type
@afontcu Thank you for this! This makes building custom |
Having
MountingOptions
available in Vue Testing Library will improve greatly the DX of people using the library.