Add the correct display to <details> in IE and Edge #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It looks like |
|
You're welcome. I was also surprised by the lack of support in Edge. Good to know it has caught up with the other browsers. |
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<details>and<summary>elements are not supported in IE and Edge. Adding a polyfill may not be worth it but in order to apply CSS styles correctly to these elements, a correctdisplayshould be added.Adding the correct
displayto<summary>is a little bit tricky. For now, correcting thedisplayof<details>solves the problem.Screenshot: IE11 on Windows Phone 8.1.
Screenshots of IE11 and Edge on Windows 10.