Skip to content

Fix a few typos #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Fix a few typos #1466

merged 1 commit into from
Mar 6, 2018

Conversation

stakx
Copy link
Contributor

@stakx stakx commented Mar 3, 2018

Just a couple of typos that I noticed. I wasn't quite sure whether master is the right target branch for this; if not, please let me know.

@@ -106,7 +106,7 @@ Let's take a look at the component code first:
<div class="message">
{{ message }}
</div>
Enter your username: <input v-model="usernane">
Enter your username: <input v-model="username">
Copy link
Contributor Author

@stakx stakx Mar 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this article talks about testing, I'm not 100 % sure whether this typo is intentional or not. It seems, however, that the topic is about splitting up a complex test into simpler tests, and the tests are about the character length of the input, so I'm assuming that this fix should be fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed 👍

@sdras
Copy link
Member

sdras commented Mar 6, 2018

Thank you! This looks great.

@sdras sdras merged commit 3bce1a3 into vuejs:master Mar 6, 2018
@stakx stakx deleted the typos branch March 7, 2018 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants