Skip to content

Fix vulnerabilities #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2018
Merged

Fix vulnerabilities #1718

merged 4 commits into from
Jul 26, 2018

Conversation

sdras
Copy link
Member

@sdras sdras commented Jul 21, 2018

  • We were getting a warning about a vulnerability in hoek, so updated I updated it to fix npm i hoek so it would dynamically update all instances.
  • In the process, saw that we had a few more vulnerability warnings, so ran npm audit fix to update 9 other high vulnerabilities- (68 reported in all, low through high)

@sdras sdras requested a review from chrisvfritz July 21, 2018 16:12
@sdras
Copy link
Member Author

sdras commented Jul 21, 2018 •
edited
Loading

Hm, deployment failed, looks like Netlify needs a higher version of node to be compatible with the higher hoek version. One sec.

@sdras
Copy link
Member Author

sdras commented Jul 21, 2018

Ok, this should do it. But please note that I'm also adding in node engine details here in order to get this done.

@chrisvfritz
Copy link
Contributor

Looks good to me! Thanks. 🙂

@chrisvfritz chrisvfritz merged commit 8dca36b into vuejs:master Jul 26, 2018
@potato4d potato4d mentioned this pull request Jul 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvfritz chrisvfritz Awaiting requested review from chrisvfritz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdras @chrisvfritz