Skip to content

Clarify that custom events do not bubble #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

amcsi
Copy link

@amcsi amcsi commented Aug 10, 2018

This may be a bit wordy, but I remember when I was first working with VueJS, it confused me that custom events didn't bubble up. I thought I could listen to custom events on any grandparent element.

With these changes, I would like to have this pointed out to people if I'm not alone on this.

The text I used might be a bit wordy, so feel free to suggest changes.

@amcsi
Copy link
Author

amcsi commented Nov 12, 2018

Would someone please provide some feedback about what they think about this PR?

@sdras
Copy link
Member

sdras commented Apr 8, 2019

Thanks @amcsi! Sorry about the delay.

I think this a great addition! But where it is right now breaks up the flow of the tutorial, it really belongs in the caveats section at the bottom of the page. Here are the things we would need to accept the PR:

  • Moved to the caveats section
  • Take it out of a tip
  • It would be good to mention $listeners as an alternative (let me know if you need an example, or I can follow it up with another PR to clarify)

If this all seems like too much to do after all this time, totally understandable, just ping me here and I'll close it out and open a new one.

@amcsi
Copy link
Author

amcsi commented Apr 8, 2019

@sdras thanks for the reply! That's fair enough. I don't think I will have time to do it any time soon, so feel free to close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants