Update state-management.md #2486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making the code examples consistently use `const` instead of switching to `var` as you scroll down on https://vuejs.org/v2/guide/state-management.html#Simple-State-Management-from-Scratch
|
Thank you for your contribution! We're using ES5 intentionally on Vue 2 docs, this will be changed on Vue 3 docs. |
|
oh, maybe the block in this same file: const sourceOfTruth = {}
const vmA = new Vue({
data: sourceOfTruth
})
const vmB = new Vue({
data: sourceOfTruth
})should be |
|
@adamwirth Indeed! Would you want to send a PR for it? |
adamwirth
added a commit
to adamwirth/vuejs.org
that referenced
this pull request
Feb 19, 2020
use `var` consistently. previous PR was using `const`, it should be using `var`. ref: vuejs#2486 (comment)
Ok! I made a new PR 😄 |
phanan
pushed a commit
that referenced
this pull request
Feb 19, 2020
use `var` consistently. previous PR was using `const`, it should be using `var`. ref: #2486 (comment)
vuejs-jp-bot
pushed a commit
to vuejs-jp-bot/jp.vuejs.org
that referenced
this pull request
Feb 19, 2020
use `var` consistently. previous PR was using `const`, it should be using `var`. ref: vuejs/v2.vuejs.org#2486 (comment)
potato4d
pushed a commit
to vuejs/jp.vuejs.org
that referenced
this pull request
Feb 19, 2020
use `var` consistently. previous PR was using `const`, it should be using `var`. ref: vuejs/v2.vuejs.org#2486 (comment) Co-authored-by: Adam Wirth <[email protected]>
Jinjiang
pushed a commit
to vuejs/v2.cn.vuejs.org
that referenced
this pull request
Apr 7, 2020
use `var` consistently. previous PR was using `const`, it should be using `var`. ref: vuejs/v2.vuejs.org#2486 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making the code examples consistently use
constinstead of switching tovaras you scroll down on https://vuejs.org/v2/guide/state-management.html#Simple-State-Management-from-Scratch