Skip to content

Improved Build Efficiency for Large Blog with Batch Processing: Prevent Javascript heap out of memory #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improved Build Efficiency for Large Blog with Batch Processing: Prevent Javascript heap out of memory #3285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2b1c1f
refactor: rendering pages as batch
sr2ds Dec 4, 2023
08df9c2
Merge pull request #1 from sr2ds/fix/render-massive-pages-heap-out-of…
sr2ds Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions src/node/build/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,24 +106,30 @@ export async function build(
}
}

await Promise.all(
['404.md', ...siteConfig.pages]
.map((page) => siteConfig.rewrites.map[page] || page)
.map((page) =>
renderPage(
render,
siteConfig,
page,
clientResult,
appChunk,
cssChunk,
assets,
pageToHashMap,
metadataScript,
additionalHeadTags
const pages = ['404.md', ...siteConfig.pages]
const batchSize = 100

for (let i = 0; i < pages.length; i += batchSize) {
const batch = pages.slice(i, i + batchSize)
await Promise.all(
batch
.map((page) => siteConfig.rewrites.map[page] || page)
.map((page) =>
renderPage(
render,
siteConfig,
page,
clientResult,
appChunk,
cssChunk,
assets,
pageToHashMap,
metadataScript,
additionalHeadTags
)
)
)
)
)
}
})

// emit page hash map for the case where a user session is open
Expand Down