Skip to content

check reflectionIsSupported in decorator runtime #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function componentFactory (

forwardStaticMembers(Extended, Component, Super)

if (reflectionIsSupported) {
if (reflectionIsSupported()) {
copyReflectionMetadata(Extended, Component)
}

Expand Down
4 changes: 3 additions & 1 deletion src/reflect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { VueClass } from './declarations'
// The rational behind the verbose Reflect-feature check below is the fact that there are polyfills
// which add an implementation for Reflect.defineMetadata but not for Reflect.getOwnMetadataKeys.
// Without this check consumers will encounter hard to track down runtime errors.
export const reflectionIsSupported = typeof Reflect !== 'undefined' && Reflect.defineMetadata && Reflect.getOwnMetadataKeys
export function reflectionIsSupported () {
return typeof Reflect !== 'undefined' && Reflect.defineMetadata && Reflect.getOwnMetadataKeys
}

export function copyReflectionMetadata (
to: VueConstructor,
Expand Down