Skip to content

Adjust TypeScript example #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2016
Merged

Adjust TypeScript example #45

merged 2 commits into from
Dec 14, 2016

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Dec 14, 2016

Close #44

@HerringtonDarkholme Can you check this? :)

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Dec 14, 2016

The code and README look good to me.

But I just remember why the original TypeScript version is written in render function. Because we want to use runtime build and it works with other Vue plugins.
Will it be misleading to change to full build? I have seen a lot of problems caused by pointing to wrong build in webpack config.

Edit: since our README example has already used template I think this might not be problematic, or it is at most as problematic as babel's version.

@ktsn
Copy link
Member Author

ktsn commented Dec 14, 2016

Yes, the difference of runtime/standalone build often causes the problem for beginners. But I also think using template is more natural as example because the most users would use template for ordinary components.
Since the docs and warning message is well provided now, I think we do not have to worry about that too much.

@ktsn
Copy link
Member Author

ktsn commented Dec 14, 2016

@HerringtonDarkholme Thanks!

@ktsn ktsn merged commit bd8f389 into master Dec 14, 2016
@ktsn ktsn deleted the adjust-example branch December 14, 2016 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants