Skip to content

Incorrect warning on failed commit after vue create #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spenserblack opened this issue Aug 24, 2020 · 2 comments · Fixed by #5823
Closed

Incorrect warning on failed commit after vue create #5818

spenserblack opened this issue Aug 24, 2020 · 2 comments · Fixed by #5823

Comments

@spenserblack
Copy link
Contributor

spenserblack commented Aug 24, 2020

Version

4.5.3

Environment info

Environment Info:

  System:
    OS: Linux 4.15 Ubuntu 18.04.5 LTS (Bionic Beaver)
    CPU: (2) x64 Intel(R) Xeon(R) CPU E5-1603 v3 @ 2.80GHz
  Binaries:
    Node: 14.7.0 - ~/.nvm/versions/node/v14.7.0/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.7 - ~/.nvm/versions/node/v14.7.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 79.0
  npmGlobalPackages:
    @vue/cli: 4.5.3

Steps to reproduce

  1. git config --global commit.gpgSign true to always GPG sign commits
  2. git config --global user.signingkey <your key>
  3. vue create my-project
  4. cancel GPG sign

What is expected?

Warning stating that git commit failed due to failed GPG signing

What is actually happening?

Warning stating that failure was due to missing username and email

@spenserblack
Copy link
Contributor Author

The simplest fix might be to just change the warning from Skipped git commit due to missing username and email in git config to just Could not create initial commit.

@spenserblack
Copy link
Contributor Author

Or you could pass the --no-gpg-sign flag when running git commit to prevent git from attempting to sign a commit created by vue-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants