-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(build/serve): export build/serve command and allow them to take config argument (chainable webpack config) #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make sure to hide whitespace changes in the diff viewer. Indentation is updated, so it looks like there are more changes. |
For some reason that I can not find, HMR is broken in these cases:
Yet it still works when:
|
Another method of implementing this feature would be to allow |
Worth a try. |
@Akryum I created a branch with service.run taking a 4th argument: https://github.com/nklayman/vue-cli/tree/service-run-4th-arg |
If that works I can create a PR for that instead. |
Closing as I found an alternative and lack of interest. |
Solves #1551 by changing the build command to export itself. It can then be imported and ran with a custom config that will be used instead of
api.resolveChainableWebpackConfig()
. This allows plugins to modify the webpack config only if their build command is run, not for normal builds.Edit: Now does same process for the serve command.