Skip to content

Create .editorconfig #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Create .editorconfig #2229

merged 1 commit into from
Sep 5, 2018

Conversation

Alex-Sokolov
Copy link
Collaborator

This PR add .editorconfig file which will autofix trailing spaces (common case in documentation), charsets and end-of-line styles when IDE supported it (native or via plugin)

@LinusBorg
Copy link
Member

indent_style = space
indent_size = 2

That's probably something that will make 50% of developmers mad as hell :D

We should leave that to teh developer to decide.

@Kocal
Copy link
Contributor

Kocal commented Aug 22, 2018

@LinusBorg both Vue and VuePress repos use a .editorconfig with:

indent_style = space
indent_size = 2

why shouldn't be the case here? 👀

@LinusBorg
Copy link
Member

Oh, I misread the change. I thought it was added to the default template for a fresh project.

It's probably fine for the repo itself.

@haoqunjiang haoqunjiang merged commit 8582a08 into vuejs:dev Sep 5, 2018
@Alex-Sokolov Alex-Sokolov deleted the patch-1 branch September 5, 2018 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants