Add support for metalsmith builder hooks #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2017
kazupon
approved these changes
Apr 5, 2017
|
I think this would be even better with tests. |
|
I'll write one test that writes target files to another destination, as I think it would be a common use case. |
|
Test written. I have also removed |
zigomir
reviewed
Apr 6, 2017
| @@ -254,7 +265,7 @@ describe('vue-cli', () => { | |||
| expect(getTemplatePath('../template')).to.equal(path.join(__dirname, '/../../../template')) | |||
| }) | |||
|
|
|||
| it.only('points out the file in the error', done => { | |||
zigomir
suggested changes
Apr 6, 2017
| delete files['readme.md'] | ||
| files['custom/readme.md'] = readme | ||
|
|
||
| console.log(files) |
There was a problem hiding this comment.
I believe this could be removed.
|
|
||
| var readme = files['readme.md'] | ||
| delete files['readme.md'] | ||
| files['custom/readme.md'] = readme |
There was a problem hiding this comment.
Just to be sure. What you're doing here in custom metalsmith plugin is you're moving file from root template directory into custom directory, right?
| @@ -0,0 +1,17 @@ | |||
| module.exports = { | |||
| "metalsmith": function (metalsmith, opts, helpers) { | |||
There was a problem hiding this comment.
Besides this one you can also test before and after, right?
There was a problem hiding this comment.
I just push a new commit with an additional test, and better assertions
Toilal
force-pushed
the
feature/metalsmith-builder-hooks
branch
from
0a8c6a7 to
0125ac7
Compare
zigomir
approved these changes
Apr 9, 2017
|
@Toilal looks good, thank you! |
This was referenced Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #427