Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports for Vue.js 2.6 "Macross" #39

Closed
mysticatea opened this issue Feb 5, 2019 · 3 comments
Closed

Supports for Vue.js 2.6 "Macross" #39

mysticatea opened this issue Feb 5, 2019 · 3 comments
Assignees
@mysticatea
Labels
accepted enhancement

Comments

@mysticatea
Copy link
Member

https://medium.com/the-vue-point/vue-2-6-released-66aa6c8e785e

There are two new syntaxes. This parser should support those.
@mysticatea mysticatea self-assigned this Feb 5, 2019
mysticatea added a commit that referenced this issue Feb 5, 2019
@mysticatea
✨ support v-slot [RFC0001] (refs #39)
ff1a51a
mysticatea added a commit that referenced this issue Feb 5, 2019
@mysticatea
✨ support v-slot shorthand [RFC0002] (refs #39)
809009d
@mysticatea
Copy link
Member Author

Hmm.

It needs a breaking change about the tokens of VDirectiveKey nodes. Currently, because an attribute name is an atom, a VDirectiveKey node is expressed by one token. However, dynamic arguments can have a JavaScript expression, it will be expressed by multiple tokens. Though, we cannot insert any whitespace into dynamic arguments.

mysticatea added a commit that referenced this issue Feb 5, 2019
@mysticatea
💥 support dynamic argument [RFC0003] (refs #39)
53f246a 
This commit contains a breaking change about the tokens of VDirectiveKey
nodes.
@mysticatea
Copy link
Member Author

And we need to support .prop shorthand notation: vuejs/vue#7582

I'm worried how we express it in AST. 🤔

mysticatea added a commit that referenced this issue Feb 6, 2019
@mysticatea
💥 change VDirectiveKey AST (refs #39)
baf8e46 
It's strange if a property can be either an AST node or other primitive value. It should not mix AST nodes and primitive values which are
except null.
Therefore, this commit changes the member of VDirectiveKey node to AST
nodes from the mix of string and AST node.
mysticatea added a commit that referenced this issue Feb 7, 2019
@mysticatea
💥 remove shorthand property from VDirectiveKey node (refs #39)
69934be
mysticatea added a commit that referenced this issue Feb 7, 2019
@mysticatea
✨ support .property shorthand (refs #39)
bc89f92
mysticatea added a commit that referenced this issue Feb 7, 2019
@mysticatea
✨ add parsing error about invalid dynamic argument (refs #39)
9326fa0
@mysticatea
Copy link
Member Author

Added in 0f24127...3c356d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mysticatea mysticatea

Labels
accepted enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mysticatea