chore: add missing dependencies #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
|
@yyx990803 Done. |
|
Yes, it does allow accessing |
znck
requested changes
Jun 5, 2018
|
@znck They were required to pass the tests with pnpm. In other words, they were "require"d from the tests transitively before, which is not good because you don't control the version you get. |
znck
approved these changes
Jun 6, 2018
|
Vue is unusable without |
|
There are merge conflicts now |
alfredriesen
added a commit
to alfredriesen/vue-loader
that referenced
this pull request
Jan 23, 2019
* https://github.com/vuejs/vue-loader: (23 commits) chore: changelog 15.6.0 feat: make `__file` injection opt-in in production (vuejs#1475) fix: template comments replace windows \ to / confirm consistent hash (vuejs#1477) docs(zh): updated eslint plugin link (vuejs#1471) chore: todo [ci skip] feat: support for compiler 2.6 outputSourceRange feat: support webpack 5 hooks (vuejs#1469) docs: [RU] Translation update (vuejs#1470) chore: changelog 15.5.1 fix: avoid to generate empty css chunk files (vuejs#1464) chore: changelog 15.5.0 feat: add `prettify` option (vuejs#1461) chore: add missing dependencies (vuejs#1336) fix: css modules extends error (vuejs#1452) docs: [RU] Translation update (vuejs#1448) Update eslint-plugin-vue documentation link (vuejs#1444) docs: remove unnecessary `path` module usage (vuejs#1430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for pnpm compatibility.
For full compatibility, vuejs/vue-style-loader#24 is also needed.