Skip to content

[Docs] Full text search for vue-router docs. #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicedaichi3 opened this issue Oct 18, 2018 · 2 comments · Fixed by #2537
Closed

[Docs] Full text search for vue-router docs. #2439

nicedaichi3 opened this issue Oct 18, 2018 · 2 comments · Fixed by #2537

Comments

@nicedaichi3
Copy link
Contributor

What problem does this feature solve?

Hello :)
I'd like to full text search for vue-router docs.
beforeRouteLeave and others do not hit in header search.

VuePress comes with built-in headers-based search - it automatically builds a simple search index from the title, h2 and h3 headers from all the pages.

Would you like to introduce Algolia like a Vuejs document ?

If you give Algolia's API key specific to this document, I'll fix the code and commit it.
https://vuepress.vuejs.org/theme/default-theme-config.html#algolia-search

You have something to worry about, please let me know.

Thank you.

@posva
Copy link
Member

posva commented Oct 18, 2018

Oh yeah, that's something we could add

@nicedaichi3
Copy link
Contributor Author

Hi @posva
Could you please give me a hint how to get Algolia API Key for this docs.
Probably I think I should process on this refs: vuejs/v2.vuejs.org#575

Haroenv added a commit to Haroenv/vue-router that referenced this issue Dec 17, 2018
I enabled the Algolia DocSearch crawler on this site, like on other Vue utilities, so that we can search in the bodies of the documentation too!

fixes vuejs#2439
posva pushed a commit that referenced this issue Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants