Skip to content

Fix #1572 router-link in nested component behaves differently than one in a page-route #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lzxb
Copy link

@lzxb lzxb commented Dec 1, 2017

Fix #1572

The reason for bug is that the state of the parent component is modified

@posva
Copy link
Member

posva commented Jan 13, 2018

Sorry I didn't answer yet. The reason I didn't merge it yet is that using { name: 'app' } without provided all of the params should not be allowed. I'm also concerned that navigating to a route with optional parameters that way could reuse parameters from the current route. I need a bit more time to investigate this one. See #1572 (comment)

@posva
Copy link
Member

posva commented Apr 11, 2018

Thanks for the PR, at then end we are going with #2029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants