Skip to content

Documentation: Update guard example to avoid stack overflow #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2020
Merged

Documentation: Update guard example to avoid stack overflow #3129

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc204a3
Update guard example to avoid stack overflow
NoelDeMartin Feb 21, 2020
55496d4
Update docs/guide/advanced/navigation-guards.md
NoelDeMartin Feb 23, 2020
1050fd9
Use route name in next() call for consistency
NoelDeMartin Feb 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/guide/advanced/navigation-guards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Every guard function receives three arguments:
```js
// BAD
router.beforeEach((to, from, next) => {
if (!isAuthenticated) next('/login')
if (to.path !== '/login' && !isAuthenticated) next('/login')
// if the user is not authenticated, `next` is called twice
next()
})
Expand All @@ -48,7 +48,7 @@ router.beforeEach((to, from, next) => {
```js
// GOOD
router.beforeEach((to, from, next) => {
if (!isAuthenticated) next('/login')
if (to.path !== '/login' && !isAuthenticated) next('/login')
else next()
})
```
Expand Down