feat: export RouterLink RouterView #3733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router-docs-v3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
xiaoxiangmoe
force-pushed
the
dev
branch
2 times, most recently
from
4da01d5 to
f5d5e11
Compare
posva
requested changes
Mar 2, 2022
xiaoxiangmoe
force-pushed
the
dev
branch
6 times, most recently
from
2dac0eb to
df03030
Compare
posva
approved these changes
Mar 4, 2022
posva
requested changes
Apr 5, 2022
| @@ -0,0 +1,90 @@ | |||
| import Vue, { AsyncComponent, ComponentOptions, PluginFunction } from 'vue' | |||
There was a problem hiding this comment.
can you put this back where it was?
There was a problem hiding this comment.
I put it in a separate file because I want to unravel the circular dependency.
VueRouter depends on RouterView and RouterLink
RouterLink depends on NavigationFailure and Route
But VueRouter and NavigationFailure and Route are defined intypes/router.d.ts.
Should we allow circular dependency here?
| @@ -1,4 +1,4 @@ | |||
| import Vue, { ComponentOptions, PluginFunction, AsyncComponent } from 'vue' | |||
There was a problem hiding this comment.
can you keep the original filename?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.