test(v-stream): ensure the data gets passed correctly also on custom component #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regou
approved these changes
May 16, 2019
I don’t know why. And further PRs are welcomed! |
|
Hey @briwa, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I saw a fix for #106, and I just thought that it could have been prevented by a test case so that similar problems won't happen again. What I did was just modifying the current test case for
v-streamwith data so that it also tests custom component instead of just a native element.Also, just curious, why isn't the test using
vue-test-utils? Is it because it's still in beta? I don't mind doing the refactor if it should be the way to go.Let me know what you think. Thanks.