Skip to content

docs: add suggestion to deprecated attachToDocument #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Jul 8, 2020

Closes #1584

Just a mirror of #1584, which fails on Prettier unexpectedly (AFAIK).

@afontcu
Copy link
Member Author

afontcu commented Jul 8, 2020

Looks like build is passing. I'm going to merge this.

All credit goes to @alexmiddeleer ;)

@afontcu afontcu requested a review from lmiller1990 July 8, 2020 12:21
@afontcu afontcu mentioned this pull request Jul 8, 2020
@afontcu afontcu merged commit 69ea054 into dev Jul 8, 2020
@afontcu afontcu deleted the update-docs-attachto branch July 8, 2020 13:45
lmiller1990 pushed a commit that referenced this pull request Jun 13, 2021
Closes #1725

Updates  attachToDocument documentation tip from the div boilerplate from #1584 & #1611 to the new handling from #1578 & #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attachToDocument deprecated and no documented substitute?
2 participants