Skip to content

fix: #455 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: #455 #661

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51f8a14
add updated hook
38elements May 26, 2018
d09045a
fix #582
38elements May 27, 2018
9e9a863
add test for child component
38elements May 30, 2018
4952874
remove code for #455
38elements May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/specs/mounting-options/sync.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,17 @@ describeWithShallowAndMount('options.sync', (mountingMethod) => {
})

it('call updated when sync is not false', () => {
const fooSpy = sinon.stub()
const Foo = {
template: '<div>{{ foo }}</div>',
props: ['foo'],
updated () {
fooSpy()
}
}
const spy = sinon.stub()
const TestComponent = {
template: '<div>{{ foo }}</div>',
template: '<div>{{ foo }}<foo :foo="foo" /></div>',
data () {
return {
foo: 'foo'
Expand All @@ -126,10 +134,14 @@ describeWithShallowAndMount('options.sync', (mountingMethod) => {
}
}
const wrapper = mountingMethod(TestComponent, {
stubs: { foo: Foo },
sync: true
})
expect(spy.notCalled).to.equal(true)
expect(fooSpy.notCalled).to.equal(true)
wrapper.vm.foo = 'bar'
expect(spy.calledOnce).to.equal(true)
expect(fooSpy.calledOnce).to.equal(true)
expect(wrapper.html()).to.equal('<div>bar<div>bar</div></div>')
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyerburgh

One question with this PR—I don't think child components will call update with this solution?

Since this test passed, child components are updated.

})