Skip to content

refactor: silentWarnings -> silent #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2018
Merged

refactor: silentWarnings -> silent #727

merged 2 commits into from
Jun 17, 2018

Conversation

38elements
Copy link
Contributor

@38elements 38elements commented Jun 16, 2018 •
edited
Loading

This add silentWarnings type.
This renames silentWarnings to silent.

@eddyerburgh
Copy link
Member

I know this isn't part of the PR, but I actually think we should rename silentWarnings to silent to keep the same API as Vue.

Can you make that change in this PR?

@38elements 38elements changed the title fix(types): add silentWarnings refactor: silentWarnings -> silent Jun 17, 2018
@38elements
Copy link
Contributor Author

Thank you for reply.
I changed them.

eddyerburgh
eddyerburgh approved these changes Jun 17, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eddyerburgh eddyerburgh merged commit 7302e05 into vuejs:dev Jun 17, 2018
@38elements 38elements deleted the silentWarnings branch June 17, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@38elements @eddyerburgh