Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(runtime-vapor): onMounted and onUnMounted hook #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime-vapor): onMounted and onUnMounted hook #43
Changes from 1 commit
093fbd9
719601b
4bc650b
c301020
26308c5
0521be9
341ddf0
45e86e3
da8e196
4b4cb05
0c26b0d
ecf7da9
12250a8
b421aa9
d1dd1e1
6852ade
98d48e7
4855284
cef4d28
25bdc24
bc72922
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand the handling of this flag. @sxzz
At the very least, if implementing 'isUnmounted', it would probably be good to rewrite it as true during unmount.
ref: #42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of 'isUnmounted' in 'runtime-core' is false, so I have set it to false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that seems to be the correct default value,
but I do think it should be marked as true when the Component is unmounted.
https://github.com/vuejs/core-vapor/pull/43/files#diff-e05b05171d6196eb88c0845a17e0482ab342a992e8e388da3dca363fadeafc08R67-R80
(However, currently when unmounting, the implementation sets isMounted to false, so I'm not quite clear on how these two flags should be treated...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot. My bad. 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, please don't feel bad. 😸
In any case, since I don't have a clear grasp of how these two flags should be treated, I'd like to leave the rest to @sxzz ...