Skip to content

wip: template component support #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pikax
Copy link
Member

@pikax pikax commented Jan 2, 2024

Simple support for rendering component.

Implementation can be better, still work in progress.

Copy link

github-actions bot commented Jan 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.5 kB 34 kB 30.7 kB
runtime-vapor.global.prod.js 23.4 kB (+79 B) 8.9 kB (+35 B) 8.2 kB (+17 B)
vue-vapor.global.prod.js 59.6 kB (+1.41 kB) 20.4 kB (+483 B) 18.5 kB (+466 B)
vue.global.prod.js 147 kB 53.3 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.8 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.8 kB 19 kB
defineCustomElement 52.1 kB 20.3 kB 18.5 kB
vapor 23.2 kB (+77 B) 8.92 kB (+32 B) 8.21 kB (+28 B)
overall 63.3 kB 24.5 kB 22.2 kB

@sxzz sxzz force-pushed the main branch 2 times, most recently from 2f9e25d to 0255505 Compare January 25, 2024 09:00
@sxzz sxzz closed this Jan 28, 2024
@sxzz sxzz reopened this Jan 28, 2024
@sxzz sxzz closed this Jan 28, 2024
@sxzz sxzz reopened this Jan 28, 2024
@sxzz sxzz closed this Jan 28, 2024
@sxzz sxzz reopened this Jan 28, 2024
@sxzz sxzz closed this Jan 28, 2024
@sxzz
Copy link
Member

sxzz commented Jan 28, 2024

I don't know why but I cannot re-open the PR. It will be closed immediately. I have no idea about this.


Update: I believe it is because vuejs/core-vapor is no longer a fork of core. We have to fork this repository and re-create a new PR. Feel sorry.

@ubugeeei
Copy link
Member

It seems I can't specify core-vapor from the branch I created before.
I'll try creating a sub-branch directly under core-vapor :D

スクリーンショット 2024-01-28 22 25 08

@sxzz
Copy link
Member

sxzz commented Jan 28, 2024

Actually, @ubugeeei has write access to this repo and can push your branch directly without a fork.

@ubugeeei
Copy link
Member

Yes, that method worked well :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants