Skip to content

Provide a Typescript declaration file for vue-server-renderer/client-plugin #6301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hronro opened this issue Aug 5, 2017 · 6 comments · Fixed by #6325
Closed

Provide a Typescript declaration file for vue-server-renderer/client-plugin #6301

hronro opened this issue Aug 5, 2017 · 6 comments · Fixed by #6325

Comments

@hronro
Copy link

hronro commented Aug 5, 2017

What problem does this feature solve?

Please provide a declaration file, thanks.

What does the proposed API look like?

@posva
Copy link
Member

posva commented Aug 7, 2017

ping @ktsn @kazupon @HerringtonDarkholme

@ktsn
Copy link
Member

ktsn commented Aug 7, 2017

I thought about that when I wrote vue-server-renderer's typings but I'm not sure its necessity since it's used in a webpack config.
Do you write your webpack config in TypeScript?

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Aug 7, 2017

Hi @foisonocean

Would you mind provide more information? As far as I know client-plugin is for webpack. And I don't think many users use TS for webpack setup. Plus, client-plugin contains almost nothing other than a new signature).

Also, it seems adding declare module 'vue-server-render' does not work in our vue-server-render's index.d.ts.

@hronro
Copy link
Author

hronro commented Aug 8, 2017

Yes, I am using Typescript to write webpack config.

@xiuxingdeshandaiwang
Copy link

woo

@ktsn
Copy link
Member

ktsn commented Aug 8, 2017

Oh, I didn't know that webpack officially supports a config file written in TypeScript 😮
https://webpack.js.org/configuration/configuration-languages/#typescript

I'll create the declaration of client-plugin (and of server-plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants