-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancelled transitions on v-show still add the enterToClass or leaveToClass #7390
Labels
Comments
Akryum
pushed a commit
to Akryum/vue
that referenced
this issue
Jan 5, 2018
When a transition is cancelled before the next frame, the `v-enter-to` or `v-leave-to` class was still added to the element. fix vuejs#7390
lovelope
pushed a commit
to lovelope/vue
that referenced
this issue
Feb 1, 2018
This was referenced Mar 14, 2018
f2009
pushed a commit
to f2009/vue
that referenced
this issue
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this issue
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
2.5.13
Reproduction link
https://jsfiddle.net/Akryum/aa6gqqkn/
Steps to reproduce
Cancel a transition in the next frame. Example cancelling a fade-out transition:
What is expected?
The
v-enter-to
orv-leave-to
classes are not added to the element.What is actually happening?
The
v-enter-to
orv-leave-to
classes are still added to the element despite the transition being cancelled.Those lines should likely be put being a
!cb.cancelled
guard:The text was updated successfully, but these errors were encountered: