Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger when adding new property with Vue.set #12972

Closed
wants to merge 2 commits into from
Closed

fix: trigger when adding new property with Vue.set #12972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d51702
fix: trigger when adding new property with Vue.seta and piWatch test
xiaowei-one Feb 28, 2023
49af00c
fix: should be call(source)
xiaowei-one Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/v3/apiWatch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,17 @@ function doWatch(
})
} else if (isFunction(source)) {
if (cb) {
// getter with cb
getter = () => call(source, WATCHER_GETTER)
const ob = call(source, WATCHER_GETTER)
if (isReactive(ob)){
getter = () => {
;(ob as any).__ob__.dep.depend()
return ob
}
deep = true
} else {
// getter with cb
getter = () => call(source, WATCHER_GETTER)
}
} else {
// no cb -> simple effect
getter = () => {
Expand Down
11 changes: 11 additions & 0 deletions test/unit/features/v3/apiWatch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,4 +1200,15 @@ describe('api: watch', () => {
expect(parentSpy).toHaveBeenCalledTimes(1)
expect(childSpy).toHaveBeenCalledTimes(1)
})

// #12967
test('trigger when adding new property with Vue.set', async () => {
const spy = vi.fn()
const r = reactive({ exist: 5 })
watch(() => r, spy, { deep: true })
set(r, 'add', 1)

await nextTick()
expect(spy).toHaveBeenCalledTimes(1)
})
})