Skip to content

fix(#6778): pass async error to outside callback to display right response #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(#6778): pass async error to outside callback to display right response #7208

wants to merge 1 commit into from

Conversation

kyle7zhang
Copy link

pass async error to outside callback to handle error correct and response right status (not 200)

BREAKING CHANGE: RenderContext.prototype.next pass error object to outside callback

close #6778

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

RenderContext.prototype.next now can pass error object to outside callback, and handle it correctly when an async error happened.

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

pass async error to outside callback to handle error correct and
response right status (not 200)

BREAKING CHANGE: RenderContext.prototype.next pass error object to
outside callback

close #6778
@kyle7zhang kyle7zhang closed this Dec 8, 2017
@kyle7zhang kyle7zhang reopened this Dec 8, 2017
@kyle7zhang kyle7zhang closed this Dec 8, 2017
@kyle7zhang kyle7zhang reopened this Dec 8, 2017
@kyle7zhang kyle7zhang changed the title fix(ssr): pass async error to outside callback to display right response fix(ssr): pass async error to outside callback to display right response #6778 Dec 10, 2017
@kyle7zhang kyle7zhang changed the title fix(ssr): pass async error to outside callback to display right response #6778 fix(ssr): pass async error to outside callback to display right response fix #6778 Dec 10, 2017
@kyle7zhang kyle7zhang changed the title fix(ssr): pass async error to outside callback to display right response fix #6778 fix(#6778): pass async error to outside callback to display right response Dec 10, 2017
@yyx990803
Copy link
Member

Thanks a lot for this PR! It is not entirely correct, but it has helped a lot in locating the problem. I ended up with a fix in 8936b8d.

@yyx990803 yyx990803 closed this Dec 12, 2017
@kyle7zhang kyle7zhang deleted the fix-bug-6778 branch December 13, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR: renderToString is called without an err & source-maps not used in stack traces of lazy-loaded components
2 participants