fix #7367: Replace isAndroid with window.ConpositionEvent. #7368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeuisKen
changed the title
dsonet
reviewed
Jan 5, 2018
| @@ -39,7 +39,7 @@ const directive = { | |||
| // this also fixes the issue where some browsers e.g. iOS Chrome | |||
| // fires "change" instead of "input" on autocomplete. | |||
| el.addEventListener('change', onCompositionEnd) | |||
| if (!isAndroid) { | |||
| if (typeof window.CompositionEvent === 'function') { | |||
There was a problem hiding this comment.
Dectect this everytime is not a good idea.
There was a problem hiding this comment.
Refactor as your suggestion, thx : )
run isCompositionEventSupported check only once according to the code review suggestion. and since e.target.composing only set by onCompositionStart handler, and when isCompositionEventSupported === false there is no onCompositionStart handler, so move the onCompositionEnd handler of change event into the if condition.
|
Thanks for the PR - this should be safe to be always enabled. See f7ca21e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
#7367