-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
allow functional components to return multiple VNodes (fix #8191) #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes #8191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can we add a test case for this?
Silly me. I assumed that since vue was preliminary a Javascript project, it wouldn't have the typescript toolchain installed, and therefore wouldn't be able to test the types. I'll add a test for this to |
051acda
to
699f44d
Compare
@ktsn @LinusBorg Is this a public API ? I checked the doc here https://vuejs.org/v2/api/#render and here https://vuejs.org/v2/api/#render. But it seems nowhere mentions multiple root. |
The most official source I've seen on the topic has been a core team member here suggesting it as an option at #7088 (comment) Given that articles like https://zendev.com/2018/05/07/multi-root-vue-components.html are starting to pop up, it probably ought to be added to https://vuejs.org/v2/guide/render-function.html#Functional-Components. I'm surprised it wasn't already. |
@HerringtonDarkholme It's definitely official API. It's one of the reasons functional components were created in the first place. But looking at the current documentation, it's not mentioned (anymore?) /cc @chrisvfritz |
Oh, I thought I did mention it. I'll add it. 👍 |
is there anything holding this up? |
poking this again, is there anything else I need to do to get this merged? |
Please be patient, we are currently wrapping up work on other core projects and will return attention back to the core repository shortly. |
No worries. Thanks for the update :-) |
3 months later, what's holding this up? Also this requires possible return value |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: