Fix two errors with the clientManifest #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. In the text, it said that `clientManifest` would only be used in `createBundleRenderer`. I tried it, and it works with the normal renderer, too. 2. The client build manifest is generated by the `vue-server-renderer/client-plugin`, not by `vue-server-renderer/server-plugin`
kazupon
pushed a commit
that referenced
this pull request
Jul 9, 2017
* Translate css.md via GitLocalize * Translate css.md via GitLocalize * Update css.md Remove style closing tags * Translate css.md via GitLocalize * Update css.md
kazupon
added a commit
that referenced
this pull request
Jul 9, 2017
* Translate SUMMARY.md via GitLocalize * Revert "Chinese Translation: zh/summary" * Revert "Revert "Chinese Translation: zh/summary"" * Japanese Translation: ja/css.md (#19) * Translate css.md via GitLocalize * Translate css.md via GitLocalize * Update css.md Remove style closing tags * Translate css.md via GitLocalize * Update css.md * Translate api.md via GitLocalize * Translate streaming.md via GitLocalize (#22) * Translate caching.md via GitLocalize (#23) * Japanese Translation: ja/routing.md (#18) * Translate routing.md via GitLocalize * Translate routing.md via GitLocalize * Translate universal.md via GitLocalize (#29) * ja/api.md (#28) * Translate api.md via GitLocalize * Translate api.md via GitLocalize * Translate api.md via GitLocalize * Translate api.md via GitLocalize * Translate build-config.md via GitLocalize (#27) * Translate build-config.md via GitLocalize * Translate build-config.md via GitLocalize * Translate build-config.md via GitLocalize * Japanese translation: bundle-renderer.md (#30) * Translate bundle-renderer.md via GitLocalize * Translate bundle-renderer.md via GitLocalize * Translate basic.md (#32) * Translate basic.md via GitLocalize * Translate basic.md via GitLocalize * Translate basic.md via GitLocalize * Translate basic.md via GitLocalize * Japanese Translation: ja/data.md (#25) * Translate data.md via GitLocalize * Translate data.md via GitLocalize * Fix typos * コード内のコメントを日本語に翻訳した * コード内のコメントの意図をより明確にした * expose はモジュールとしての公開するという意味なので訳を変更した * 原文に ... とあるので一応残しておく * "Client Side Hydration" の翻訳 (#36) * Translate hydration.md via GitLocalize * Translate hydration.md via GitLocalize * Japanese Translation: ja/head.md (#33) * Translate head.md via GitLocalize * Translate head.md via GitLocalize * expose はモジュールとして公開するという意味なので公開という言葉を使うようにした * コードのコメントの翻訳が漏れていた * Japanese Translation: ja/routing.md (#38) * Translate routing.md via GitLocalize * Translate routing.md via GitLocalize * Japanese Translation: ja/caching.md (#37) * Translate caching.md via GitLocalize * Translate caching.md via GitLocalize * translated the "source code structure" into Japanese. (#26) * Translate structure.md via GitLocalize * Translate structure.md via GitLocalize * Translate structure.md via GitLocalize * Japanese Translation: ja/SUMMARY.md (#35) * Translate SUMMARY.md via GitLocalize * hydration.md と合わせた "Client Side Hydration" の翻訳 by hikimon · Pull Request #36 · open-source-translators/vue-ssr-docs open-source-translators#36 * en/ に合わせてインデントを 2 にした * Renderer 生成時の各オプションの階層を下げた。en/ でもそうなっている * Japanese translation: readme.md (#39) * Translate README.md via GitLocalize * Translate README.md via GitLocalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientManifestwould only be used increateBundleRenderer. I tried it, and it works with the normal renderer, too.vue-server-renderer/client-plugin, not byvue-server-renderer/server-plugin