Skip to content

Missing sidebar button on a mobile homepage #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Vladislav-Lyuminarskiy opened this issue Feb 25, 2019 · 2 comments
Closed
1 task done

Missing sidebar button on a mobile homepage #1355

Vladislav-Lyuminarskiy opened this issue Feb 25, 2019 · 2 comments
Labels
has PR Has a related PR type: bug Something isn't working version: 0.x Relates to version 0 of VuePress

Comments

@Vladislav-Lyuminarskiy
Copy link
Contributor

  • I confirm that this is a issue rather than a question.

Bug report

Version

0.14.9.

Steps to reproduce

  1. Add a navbar.
  2. Open mobile homepage.

What is expected?

  1. Navbar is hidden.
  2. Sidebar button is visible.

What is actually happening?

  1. Navbar is hidden.
  2. Sidebar button is also hidden.

Demo: https://oop-course.github.io/en/

Homepage with a sidebar on an iPad:
52947839-4d336880-3391-11e9-9605-f43bc82ef453

Same page on an iPhone (sidebar button is missing):
52947845-502e5900-3391-11e9-9cb3-f3b7cc3b49a7

Other relevant information

Sourse of the bug: #1159

  • Your OS: Windows 10 1809
  • Node.js version: 10.9.0
  • Browser version: Google Chrome 72.0.3626.109
  • Global install.
  • NPM.
  • VuePress v0 doesn't support plugins.
Merged
18 tasks
@ulivz ulivz added type: bug Something isn't working version: 0.x Relates to version 0 of VuePress labels Feb 26, 2019
sinchang added a commit to XChangLab/vuepress that referenced this issue Feb 27, 2019
@sinchang
fix:
c3ffbfa 
missing sidebar button on a mobile homepage

fix vuejs#1355
sinchang added a commit to XChangLab/vuepress that referenced this issue Feb 27, 2019
@sinchang
fix: missing sidebar button on a mobile homepage
f5b4be5 
fix vuejs#1355
@sinchang sinchang mentioned this issue Feb 27, 2019
Merged
18 tasks
@shigma shigma added the has PR Has a related PR label Feb 27, 2019
shigma pushed a commit that referenced this issue Feb 27, 2019
@sinchang @shigma
fix: missing sidebar button on a mobile homepage (close: #1355) (#1361)
ae7013f 
* Revert "fix: sidebar button should be hidden when there are no sidebars in mobile side (#1159)"

This reverts commit b7f3ac4.

* Fix indent
@shigma shigma closed this as completed Feb 28, 2019
@ulivz
Copy link
Member

ulivz commented Mar 2, 2019

Now it's out at v0.14.10.

@alcuadrado
Copy link

I was dealing with this same issue yesterday. I can confirm that v.0.14.10 fixes it. Thank you!

rmjordas added a commit to rmjordas/awesome-vue that referenced this issue Mar 14, 2019
@rmjordas
Update package manifest
56c29b5 
Bumps the vuepress dependency to version 0.14.10 to fix the missing
sidebar btton on a mobile homepage issue. This version introduces a bug
when running the development server but is temporarily fixed by adding
[email protected] as a devDependency.

See:
- vuejs/vuepress#1355
- vuejs/vuepress#1417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR Has a related PR type: bug Something isn't working version: 0.x Relates to version 0 of VuePress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alcuadrado @Vladislav-Lyuminarskiy @ulivz @shigma