Skip to content

fix: missing sidebar button on a mobile homepage (close: #1355) #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

sinchang
Copy link
Contributor

@sinchang sinchang commented Feb 27, 2019

Summary

This reverts commit b7f3ac4

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
    fix Missing sidebar button on a mobile homepage #1355
    You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome

  • Firefox

  • Safari

  • Edge

  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@sinchang sinchang changed the title fix: missing sidebar button on a mobile homepage [WIP] fix: missing sidebar button on a mobile homepage Feb 27, 2019
@sinchang sinchang changed the title [WIP] fix: missing sidebar button on a mobile homepage fix: missing sidebar button on a mobile homepage Feb 27, 2019
@shigma shigma changed the title fix: missing sidebar button on a mobile homepage fix: missing sidebar button on a mobile homepage (close: #1355) Feb 27, 2019
@shigma shigma merged commit ae7013f into vuejs:0.x Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants