Skip to content

documentation of google analytics plugin wrt IP anonymization #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shadiakiki1986 opened this issue Jul 5, 2019 · 3 comments · Fixed by #1724
Closed

documentation of google analytics plugin wrt IP anonymization #1687

shadiakiki1986 opened this issue Jul 5, 2019 · 3 comments · Fixed by #1724
Labels
contribution welcome Contributions welcome

Comments

@shadiakiki1986
Copy link

shadiakiki1986 commented Jul 5, 2019

Feature request

What problem does this feature solve?

The documentation page here says "consider setting Google Analytics to anonymize IPs",

but he plugin source code already enables IP anonymization (ref).

I was mislead by the documentation to think that I need to make a modification or configuration somewhere to enable IP anonymization.

What does the proposed API look like?

The documentation should say that IP anonymization is already enabled in this plugin (in version 1 and not in v0?)

How should this be implemented in your opinion?

Maybe re-word the statement

Are you willing to work on this yourself?

Sure!

PS: Awesome project!

@ulivz
Copy link
Member

ulivz commented Jul 15, 2019

Thanks for the suggestion, welcome to help us to enhance the docs!

@ulivz ulivz added the contribution welcome Contributions welcome label Jul 15, 2019
@shadiakiki1986
Copy link
Author

shadiakiki1986 commented Jul 15, 2019 via email

@ulivz
Copy link
Member

ulivz commented Jul 21, 2019

@shadiakiki1986 Yes, feel free to submit it.

ulivz pushed a commit that referenced this issue Jul 28, 2019
Changed wording to accomadate already anaonymized IPs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants