Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable editLink on specific page #1762

Closed
kefranabg opened this issue Aug 8, 2019 · 2 comments · Fixed by #1825 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed

Enable editLink on specific page #1762

kefranabg opened this issue Aug 8, 2019 · 2 comments · Fixed by #1825 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Labels
good first issue Good for newcomers topic: config Relates to VuePress config type: feature request Request to add a new feature

Comments

@kefranabg
Copy link
Collaborator

kefranabg commented Aug 8, 2019

Feature request

For now we can globally enable editLinks (for page edition) and disable it per page with editLink front matter property, but we can't do the opposite: Having global editLinks prop to be false, and enable editLink per page.

For example:

If themeConfig.editLinks from my .vuepress/config file is false and editLink from one of my pages is true, it won't work, the page will not show the edit link.

What problem does this feature solve?

If I want only one page of my app to be editable, I need to enable page edition globally and then set editLink to false on all other pages . We should be able to do the opposite

What does the proposed API look

We should use editLinks property from themeConfig by default, and overwrite it with the editLink property defined on the current page if it exists.

How should this be implemented in your opinion?

This behavior has been implemented for next/previous links in this commit

Are you willing to work on this yourself?

Why not, however it could be a good first issue for external contributors 😉

@kefranabg kefranabg added good first issue Good for newcomers type: feature request Request to add a new feature topic: config Relates to VuePress config labels Aug 8, 2019
@edisdev
Copy link
Contributor

edisdev commented Aug 9, 2019

Wow, I think good idea :) If you don't mind, I'd like to contribute to this feature . :) @kefranabg

@pniedzwiedzinski
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers topic: config Relates to VuePress config type: feature request Request to add a new feature
Projects
None yet
3 participants