Skip to content

Misc docs improvements #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 16, 2020
Merged

Misc docs improvements #577

merged 11 commits into from
Dec 16, 2020

Conversation

scarletfog
Copy link
Contributor

Context

Several smaller things to improve - better wording, styling for tables, removal of the roadmap page (as requested).

How has this been tested?

I ran the documentation locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. Misc improvements to the documentation (API and guide) #572

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #577 (22937df) into develop (a9ee306) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #577   +/-   ##
========================================
  Coverage    92.59%   92.59%           
========================================
  Files          162      162           
  Lines        37282    37282           
  Branches      5406     5406           
========================================
  Hits         34520    34520           
  Misses        2755     2755           
  Partials         7        7           

@scarletfog scarletfog marked this pull request as ready for review December 14, 2020 13:25
@scarletfog
Copy link
Contributor Author

@wojciechczerniak I need your help here with two things -

  1. I could not resolve an issue we have with "help us improve this page" that leads to 404, for example: https://handsontable.github.io/hyperformula/api/ - I tried to play with frontmatter as I found this issue: Enable editLink on specific page vuejs/vuepress#1762 but without success - it's displayed just like a normal text.
  2. Which file could be used to count the current number of available functions? In the config file, I saw we have HyperFormula.version, HyperFormula.buildDate, HyperFormula.releaseDate and I suspect we should add something similar: HyperFormula.functionsNumber to be later used as: {{ $page.functionsNumber }}.

@wojciechczerniak
Copy link
Contributor

@scarletfog see d1f41b2

@scarletfog
Copy link
Contributor Author

Ah, thank you so much @wojciechczerniak!

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇

@scarletfog scarletfog merged commit 72c3d5f into develop Dec 16, 2020
@scarletfog scarletfog deleted the misc_doc_improvements/issue-572 branch December 16, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants