-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Please remove the words "TIP" and "WARNING" from custom containers #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah I see you can do it like this
does really seem to be documented. |
Hey @Maxhodges. Is the concern that there is default titles for these custom containers? Or did you just want the ability to override it?
Or are you saying you want to be able to use the styling with no title at all? |
Ideally, yes, I'd like to be able to supply my own title (in Japanese or French or example); or, use it with no title at all! I didn't realize you could override like that! Great! My bad. I'll close this issue. |
No worries at all. We should try to highlight that feature better in the docs. I'm going to reopen this issue so we address it. |
@meteorlxy Agreed, but I think the fact that it was missed means that it could be rewritten in a way that's more obvious. I'm going to experiment a bit with this to see what I can come up with. |
I just commited a PR to this issue. If this PR is good, I can make a PR for the chinese docs too. |
…uejs#2351) * docs: refine Markdown Extensions Custom Containers(fix vuejs#2141) * Update packages/docs/docs/guide/markdown.md Co-authored-by: Ben Hong <[email protected]> * Update packages/docs/docs/guide/markdown.md Co-authored-by: Ben Hong <[email protected]> * docs: simplify intro language for custom containers Co-authored-by: Ben Hong <[email protected]>
Feature request
For the customer containers plugin, please don't insert the words "TIP" or "WARNING" into the container!
What problem does this feature solve?
That makes the container much less flexible in how it could be used. I might want to use the yellow container to highlight something. But it always says "WARNING". Also, inserting these English words makes it much harder if I want to use VuePress to publish non-English content! Just leave the words out.
What does the proposed API look like?
same
How should this be implemented in your opinion?
remove lines which add "TIP" or "WARNING" to the custom containers
Are you willing to work on this yourself?
Yes!
The text was updated successfully, but these errors were encountered: