-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sidebar: auto
does not update with document changes
#2233
Comments
Update:I just noticed that changes made to |
Yes that is ture. The sidebar is rendered based on the This variable is generated when build starts, and will not change when hotload triggers. So anything related to it won't support hotload, such as sidebar, frontmatter, prev and next links, last edit time and so on. It's not a bug I think, just a feature enhancement. |
@meteorlxy @kefranabg I have seen feture request like this a few times, why not make $site.pages support hot load? I am willing to help, but I would like to ask first, as a few PR of me is not being reviewed so far.
|
I think it is a bug, see #1283 . They simply don't have the time to dig deep into it. |
I followed this issue, but uliuz adds few comment in his code, so there are about 1/3 source code of |
Then they don't have the time to create a working product because this is essential to a working product imo. |
Calling emptyDirSync every time createTemp is called - i.e, every time App.process is called; i.e., every time source files update - throws off webpack-dev-server, causing it to lose track of the source files and subdirectories. This leads to a variety of sporadic errors and breaks auto-refresh of frontmatter and configuration. Fix this by avoiding emptying temporary directories when we can detect that they were previously initialized by the same instance of the VuePress process. Fixes vuejs#1283. Fixes vuejs#2233. Fixes vuejs#2254. Fixes vuejs#2437.
Calling emptyDirSync every time createTemp is called - i.e, every time App.process is called; i.e., every time source files update - throws off webpack-dev-server, causing it to lose track of the source files and subdirectories. This leads to a variety of sporadic errors and breaks auto-refresh of frontmatter and configuration. Fix this by avoiding emptying temporary directories when we can detect that they were previously initialized by the same instance of the VuePress process. Fixes vuejs#1283. Fixes vuejs#2233. Fixes vuejs#2254. Fixes vuejs#2437.
Calling emptyDirSync every time createTemp is called - i.e, every time App.process is called; i.e., every time source files update - throws off webpack-dev-server, causing it to lose track of the source files and subdirectories. This leads to a variety of sporadic errors and breaks auto-refresh of frontmatter and configuration. Fix this by avoiding emptying temporary directories when we can detect that they were previously initialized by the same instance of the VuePress process. Fixes vuejs#1283. Fixes vuejs#2233. Fixes vuejs#2254. Fixes vuejs#2437.
Bug report
Steps to reproduce
./docs/README.md
sidebar: auto
vuepress dev docs --host localhost
What is expected?
What is actually happening?
Other relevant information
possibly related to Discrepency between TOC component and auto sidebar #1399
output of
npx vuepress info
in my VuePress project:The text was updated successfully, but these errors were encountered: