-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Define Headers to Parse during Page Prep - resolve #984 #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b84ca93
Adds the ability to specify which headers to extract during Page prep…
bretterer 0c75027
mend
bretterer 01a6d8e
Updates for PR review
bretterer 60e6dd5
Moves the extract headers option to the markdown config
bretterer 29545e6
Merge branch 'master' into page_header_parsing
bretterer c6e1f74
Merge branch 'master' into page_header_parsing
bretterer 71cad69
Adds the ability to specify which headers to extract during Page prep…
bretterer 3763e2e
mend
bretterer 3ed55e0
Updates for PR review
bretterer 06465e1
Moves the extract headers option to the markdown config
bretterer 905e2bf
Add siteConfig to the options for markdown-loader
bretterer af5b1f4
Resolve Merge Conflicts
bretterer 6eae7f2
Revert "Moves the extract headers option to the markdown config"
bretterer 0ec8c5e
Revert
bretterer 195d348
Merge branch 'page_header_parsing' of github.com:bretterer/vuepress i…
bretterer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't re-load user's config at the scope of makrdown-loader, while this loader should only focus on how to transpile the source markdown file to Vue component.
extractHeaders
should be a option for this loader.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill do some more digging, but I couldn't find any way to get to the
extractHeaders
option from within this file already.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying it should be available already inside of the loader file if defined in the
.vuepress/config.js
file such as:if that is the case, I have looked at the
this
object and could not find it anywhere.