Skip to content

Added trailing forward-slashes in link properties #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

Mike-Loffland
Copy link
Contributor

The docs show how to have sub groups inside a dropdown menu by having nested items. However, the example link text for Chinese and Japanese does not work as expected. Add the necessary trailing forward-slashes so that the code works as expected if somebody was to cut-and-paste the example as is.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • [X ] Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [X ] Chrome
  • [X ] Firefox
  • Safari
  • [ X] Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

The docs show how to have sub groups inside a dropdown menu by having nested items. However, the example link text for Chinese and Japanese does not work as expected.  Add the necessary trailing forward-slashes so that the code works as expected if somebody was to cut-and-paste the example as is.
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ulivz ulivz merged commit 2c7a13e into vuejs:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants