Fix #604 - feat: matomo plugin #1182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finding that this is broken in more than a few ways, and it may take me a bit to fix. Closing for now. |
|
Fixed but just published as my own plugin, because it's going to probably require continued updates/maintenance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Plugin for supporting Matomo analytics as a vuepress plugin. Most matomo-node or vue-matomo modules don't play well with SSR (see #604, #605), so this tries to fix that by just integrating matomo code as a 1.x plugin. Currently has minimal options, but works.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
No UI changes
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
If this isn't accepted, I can maintain the plugin as a non-official module, as it's already in use in my own vuepress projects as an in-repo plugin. However, there's been enough requests for matomo help that I figured I'd try submitting to the main project to see if there was interest. I left the maintainer entries in the package.json as the main vuepress maintainer, not sure if that would need to change to me as it would be a vuepress org owned module if accepted