Skip to content

Hosting with AWS Amplify #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2019
Merged

Hosting with AWS Amplify #1249

merged 2 commits into from
Feb 2, 2019

Conversation

swaminator
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that it’s not intentional

@swaminator
Copy link
Contributor Author

@ulivz my apologies! Definitely not intentional. I love VuePress. In fact during our beta, all our docs were on VuePress. I love the simplicity of the framework!

@HerrBertling
Copy link
Contributor

In fact during our beta, all our docs were on VuePress

Side note, sorry to hijack: If you mean these docs: https://aws-amplify.github.io/ – then please go back to VuePress 😄there are some really strange effects on mobile with the navigation and scroll behaviour in the current docs.

@swaminator
Copy link
Contributor Author

@HerrBertling no not those docs. The Amplify Console adds capabilities for deployments. We had a beta program which used Vuepress :)

@ulivz ulivz merged commit caca1db into vuejs:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants